5 Commits

Author SHA1 Message Date
Quentin Schulz
f4888f6831 themes: fix URI matching used for deciding if URI's local in menu
We want to distinguish between URI references ("local" pages), such as
path/to/another/page/of/my/website, from the other ones, such as
https://example.com in the menu to know how to build the URL.

The issue is that we did the distinction between the two by checking if
the string starts with "http".
Unfortunately, it does not match other valid URI schemes. One example is
mailto:address@example.com to open a mail client with the recipient
being address@example.com.
There are many other valid URI schemes (tel, ftp, irc, ...).
Under the current code, we think anything that isn't started by "http"
is local, i.e. we need to append the string to the parent path of the
current page.
This means that we have
https://mywebsite.example.com/mailto:address@example.com linked in the
menu instead of the expected mailto:address@example.com.

Let's fix that with a very simple test. A URI reference is commonly
detected as anything that does not contain a scheme (which has to be
suffixed by ':') or if it does, that the given path starts with './'.

This is most likely not handling all the cases but at least most of the
common ones.

Please refer to the RFC for further information:
https://www.rfc-editor.org/rfc/rfc3986.txt

Signed-off-by: Quentin Schulz <foss@0leil.net>
2019-03-20 20:56:16 +00:00
Adrien Beudin
017af6efbb update theme and fix 2018-03-27 13:43:34 +02:00
Adrien Beudin
3aa14884e3 update material theme 2018-03-27 10:52:52 +02:00
Adrien Beudin
7f8942f638 update material phase 2 2017-04-28 16:46:31 +02:00
Adrien Beudin
8c7dbc5a4a add support theme 2016-02-22 14:11:36 +01:00